Skip to content

Add guidance requiring support for zero-dimensional arrays #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

Add guidance requiring support for zero-dimensional arrays #315

merged 1 commit into from
Nov 5, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 5, 2021

This PR

@kgryte kgryte added the Narrative Content Narrative documentation content. label Nov 5, 2021
@kgryte kgryte added this to the v2021 milestone Nov 5, 2021
@kgryte kgryte requested a review from rgommers November 5, 2021 06:13
rgommers
rgommers approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

Cc @szha for visibility, because the issue explicitly mentions that MXNet currently does not support 0-D arrays. Probably on the MXNet roadmap, would be good to know for sure.

@kgryte
Copy link
Contributor Author

kgryte commented Nov 5, 2021

Thanks @leofang and @rgommers!

@kgryte kgryte merged commit aa6c89c into main Nov 5, 2021
@kgryte kgryte deleted the zero-dim-arrays branch November 5, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@leofang leofang leofang approved these changes

Assignees
No one assigned
Labels
Narrative Content Narrative documentation content.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.

Explicit rules about zero-dimensional tensors
3 participants
@kgryte @rgommers @leofang